Add an optional ttl index to expire ops#12
Open
devongovett wants to merge 2 commits intoshare:masterfrom
Open
Conversation
Member
|
Waiting on share/sharedb#33 |
Author
|
Moved logic from share/sharedb#33 here since we can catch all the errors one place. I added a bunch of tests too. The reason travis is failing is because there were some tests I had to change that live in livedb and are run here. If you run them locally and |
Author
|
@josephg do you have time to review this soon? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a revival of #7. It allows you to specify a
ttloption to livedb-mongo to expire ops after a specified time period. I'm working on another PR for livedb to handle emitting the proper errors when requested ops are missing. See share/sharedb#33.