Augment CodeMirror instance with detachShareJsDoc()#5
Open
jbpros wants to merge 1 commit intoshare:masterfrom
Open
Augment CodeMirror instance with detachShareJsDoc()#5jbpros wants to merge 1 commit intoshare:masterfrom
jbpros wants to merge 1 commit intoshare:masterfrom
Conversation
In a single app context, CodeMirror instances might be attached several times to the same shared doc. This can lead to multiple share channels attached to multiple ghost instances of CodeMirror for the same file, causing an infinite loop while the editors keep appending content to the file. This new method allows for safely disconnecting a shareJs doc from a CodeMirror instance.
Contributor
|
The build is failing. I suspect it's because you're using I expect that this change will also make the editor misbehave quite badly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a single app context, CodeMirror instances might be attached several times to the same shared doc. This can lead to multiple share channels attached to multiple ghost instances of CodeMirror for the same file, causing an infinite loop while the editors keep appending content to the file.
This new method allows for safely disconnecting a shareJs doc from a CodeMirror instance.