perf: delete feature flag checks for vm images as they are now GA #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove feature flag check from nodes/redeploy.ts - Remove feature flag check from nodes/create.ts - Remove feature flag check from nodes/image/index.ts - Remove feature flag check from vm/index.ts - Remove 'custom-vm-images' from FeatureFlags type - Update function signatures to be synchronous (no longer async) - VM image functionality now always available Co-authored-by: danieltaox <danieltaox@gmail.com>
|
Cursor Agent can help with this pull request. Just |
|
Review changes with Changed Files
|
- Remove addCreate, addRedeploy, and addImage wrapper functions - Add --image option directly in command definitions - Import and add commands directly like other commands - Change registerNodes from async to sync function - Simplify vm/index.ts to use direct command import Co-authored-by: danieltaox <danieltaox@gmail.com>
sigmachirality
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove custom VM image feature flag checks as the feature is rolling out to GA.
The
custom-vm-imagesfeature is now generally available, making the conditional logic based on its feature flag obsolete. This PR removes all related feature flag checks, making the custom VM image functionality always available. This includes removingisFeatureEnabledcalls and imports, updating theFeatureFlagstype, and converting previouslyasyncfunctions to synchronous where the feature flag check was the onlyawait.