Start/end timezone indicator #243
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add timezone detection using dayjs timezone plugin - Display user's local timezone abbreviation (e.g., PST, EST) in soonest/max columns - Use yellow color for timezone indicator to distinguish from other column headers - Increase column widths to accommodate timezone labels Co-authored-by: danieltaox <danieltaox@gmail.com>
- Use Intl.DateTimeFormat directly instead of dayjs.format('z')
- More reliable timezone abbreviation detection in Node.js environment
- Graceful fallback to UTC if timezone detection fails
Co-authored-by: danieltaox <danieltaox@gmail.com>
Co-authored-by: danieltaox <danieltaox@gmail.com>
|
Cursor Agent can help with this pull request. Just |
|
Review changes with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add timezone indicators to the "soonest" and "max" column headers in
sf zones lsto clarify the displayed times.The "START/END" columns were interpreted as "soonest" and "max" which represent start times. A
getTimezoneAbbreviation()function was added to detect the user's local timezone (e.g., PST) or default to UTC. The timezone abbreviation is displayed in yellow for better visibility.Slack Thread