Add support to gRPC #1088
Add support to gRPC #1088
Conversation
| case SERVER_STREAMING -> | ||
| handleServerStreaming(workflowContext, methodDescriptor, arguments, call); | ||
| case UNARY, UNKNOWN -> | ||
| handleBlockingUnary(workflowContext, methodDescriptor, arguments, call); |
There was a problem hiding this comment.
This should be async (you will need to complete the completable future once the result is provided)
There was a problem hiding this comment.
Do you mean to be explicit and controlled, not hidden inside gRPC?
There was a problem hiding this comment.
Instead of invoking the whole executor into a completable async and do a blocking call, I guess you can use asyncUnaryCall and make the grpc callback interact with the completable future (one instance that you create) that is returned.
There was a problem hiding this comment.
Also I think this whole lambda should be move to grpc executor (and you pass to the executor all the info required by the lamba). I know that we are mixing them in other executors (because intially I was not establishing a clear separation between the builder and the executor) but it is a good practise for clarity purposes.
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
2 participants
Changes
Do not review yet 😃
TODO
PATHbuilderCloses #1078