[PLATFORM-2992] Change Facade.library() logic#113
Open
Peripheral1994 wants to merge 1 commit intomasterfrom
Open
[PLATFORM-2992] Change Facade.library() logic#113Peripheral1994 wants to merge 1 commit intomasterfrom
Peripheral1994 wants to merge 1 commit intomasterfrom
Conversation
As currently written, Facade.library() will crash when called from Facade.device() if options.library is an object without a name property. This is because we will pass over both of the if statements in Facade.library() and attempt to run .indexOf() inside of Facade.device() on either an object literal or undefined. This adds validation to ensure that library.name exists and is a string.
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 99.21% 99.21% +<.01%
==========================================
Files 12 12
Lines 507 508 +1
Branches 162 163 +1
==========================================
+ Hits 503 504 +1
Misses 4 4
Continue to review full report at Codecov.
|
CarlosMecha
changed the title
|
Please do not merge this PR until PLATFORM-2992 gets scheduled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As currently written, Facade.library() will crash when called from Facade.device() if options.library is an object without a name property. This is because we will pass over both of the if statements in Facade.library() and attempt to run .indexOf() inside of Facade.device() on either an object literal or undefined.
This adds validation to ensure that library.name exists and is a string.