Luau type fixes for luau-lsp#57
Merged
Rider-Linden merged 3 commits intosecondlife:developfrom Jan 23, 2026
Merged
Conversation
Contributor
Author
tapple
added a commit
to tapple/lsl-definitions
that referenced
this pull request
Jan 14, 2026
tapple
added a commit
to tapple/lsl-definitions
that referenced
this pull request
Jan 14, 2026
This was referenced Jan 15, 2026
|
Pre-commit fails due to trailing whitespaces in |
Contributor
|
The trailing whitespace is fixed in #50. It's a problem in the repo itself not this pr. |
Rider-Linden
requested changes
Jan 23, 2026
Collaborator
Rider-Linden
left a comment
There was a problem hiding this comment.
There are a couple places where the luaType is set to numberic but I think it should be boolean...
| "tooltip": "Boolean, If TRUE allows anyone to drop inventory on prim, FALSE revokes.", | ||
| "type": "integer" | ||
| "type": "integer", | ||
| "luaType": "numeric" |
Collaborator
There was a problem hiding this comment.
Shouldn't this be boolean?
Contributor
There was a problem hiding this comment.
All lsl functions exposed through ll.* that accept integer in lsl, accept boolean|number in slua.
For instance
ll.SetColor(vector(1,0,0),true)The choice could be made to say we want to mark it as a boolean, but that would cause either
- linters to choke on code that saves and runs perfectly fine
- linter definition generation to do extra interpreting to figure out if it accepts something other than boolean
Collaborator
There was a problem hiding this comment.
I confused number with numeric didn't I...
Rider-Linden
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a set of PR's improving the definitions and keywords files in lsl and slua:
I significantly improved the luau types of most functions, so that luau-lsp gives less errors
Here's the diff for the generated slua-default.d.luau:
I added several fields to the definition file:
function generic<TYPE, PARAMETERS>()I'm aware the plugin isn't the master source of lua typings. I can convert this PR to xml and submit a new PR in one of or more of these places, if desired: