Skip to content

Bump actions/download-artifact from 3 to 4 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dependabot merged 3 commits into from
Feb 6, 2025
Merged

Bump actions/download-artifact from 3 to 4 #6

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed519f4
Bump actions/download-artifact from 3 to 4
dependabot[bot] Feb 5, 2025
273a2bf
Bump actions/upload-artifact from 3 to 4 (#8)
dependabot[bot] Feb 5, 2025
1b4260e
Run the Python 2.7 tests in a container, now that Actions no longer o…
nattylinden Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,30 @@ on:
jobs:
build:
name: Test & Build
container:
# Run some matrix cases in a container. If `container-image` is blank, the
# job will run conventionally on the agent.
image: ${{ matrix.container-image }}
env:
PYTHON: ${{ matrix.python-version }}
runs-on: [ubuntu-20.04]
strategy:
# Finish the other builds even if one fails.
fail-fast: false
matrix:
python-version: ['2.7', '3.7', '3.8', '3.10']
runs-on: [ubuntu-20.04]
env:
PYTHON: ${{ matrix.python-version }}
include:
- python-version: '2.7'
container-image: python:2.7
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0 # fetch all history for setuptools_scm to be able to read tags

- uses: actions/setup-python@v4
# Only set up Python if we're running directly on an agent. If we're in
# a container, the image should already provide the intended Python.
if: '! matrix.container-image'
with:
python-version: ${{ matrix.python-version }}

Expand All @@ -45,10 +57,11 @@ jobs:
if: matrix.python-version == '3.8'
with:
env_vars: PYTHON
fail_ci_if_error: true
# TODO: re-enable errors when rate limit is resolved?
# fail_ci_if_error: true
Comment on lines -48 to +61
Copy link

@nattylinden nattylinden Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this is still throwing an error uploading the coverage since we can only upload one batch of coverage data every hour or something? Until we can resolve that, let's not block changes on whether Codecov accepts our coverage data.

[2025-02-06T22:38:27.615Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 429 - {"message":"Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2427s."}

files: .coverage.${{ steps.pyenv.outputs.value }}.xml

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: matrix.python-version == '2.7' || matrix.python-version == '3.8'
with:
name: dist-${{ matrix.python-version }}
Expand All @@ -62,7 +75,7 @@ jobs:
id-token: write
if: github.event_name != 'pull_request'
steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4

- name: Organize files for upload
run: |
Expand Down
Loading