Open
Conversation
Member
Author
|
@celinedurniak please take a look and see what you think. |
Collaborator
|
Hi, From your comments at #101 (comment)
|
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

We simplify and improve the performance of the Dream instrument view, and replace the single-valued slider with a range slider for the
tofdimension.Instead of having one node per detector bank that points to the scatter3d figure, we merge all banks from the data group into a single data array.
This vastly improves performance when moving clipping planes and interacting with the time-of-flight slider.
We had to remove the checkboxes that would hide/show individual banks, but it is believed that they were not very useful in practice (see #101 (comment)).
If we want to select a subset of banks, we filter from the data group that is sent to the view before creating it.
Users most likely will want to see all banks most of the time. Dynamically toggling is probably unnecessary.
Fixes #101
This would also fix #102 if scipp/plopp#479 is added to Plopp.