BUG: fix __doctest_requires__ when constraint is present #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
reviewed
Jan 21, 2026
pllim
reviewed
Jan 21, 2026
pllim
reviewed
Jan 21, 2026
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Author
@pllim, Thank you for all your support. I took the PR out of draft. I noticed that you changed the milestone to 1.7.1. Do we need to change the first line of the changelog to 1.7.1 instead of 1.8.0? |
Contributor
I think that is at the discretion of the release manager. I feel like this is a bug and should land in a bugfix release if the next release does not contain new feature. It is not something we should worry about in this PR. |
Contributor
|
@bsipocz are you able to review the internal code changes or ping someone who can? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #318.
Also improved related unit test.