fix(arm64): use is_valid_user_address() for socketpair pointer validation #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Replace hardcoded pointer validation in sys_socketpair with architecture-aware is_valid_user_address() function to fix EFAULT errors on ARM64. Problem: - socketpair() was failing with EFAULT on ARM64 because the hardcoded check `sv_ptr > 0x7FFFFFFFFFFF` rejected ARM64 stack addresses - ARM64 stacks are at 0x0000_FFFF_FF00_0000, which is > 0x7FFFFFFFFFFF - This prevented unix_socket_test and other socket-based tests from running Solution: - Use is_valid_user_address() which correctly validates addresses for both x86-64 and ARM64 architectures - This function checks if addresses fall within valid userspace regions: - Code/data region (0x40000000 - 0x80000000) - Mmap region (0x7000_0000_0000 - 0x7FFF_FE00_0000) - Stack region (varies by architecture) Testing: - Built and tested on ARM64 - Socket pair creation now succeeds on ARM64 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sys_socketpairwith architecture-awareis_valid_user_address()functionProblem
socketpair()was failing with EFAULT on ARM64 because the hardcoded checksv_ptr > 0x7FFFFFFFFFFFrejected ARM64 stack addressesunix_socket_testand other socket-based tests from running on ARM64Solution
is_valid_user_address()which correctly validates addresses for both x86-64 and ARM64 architecturesTest plan
unix_socket_testnow passes all 18 phases on ARM64🤖 Generated with Claude Code