feat: make sql code hash independent from CR/LF line endings and leading/traiing spaces#344
Open
dmk978 wants to merge 3 commits intorust-db:mainfrom
Open
feat: make sql code hash independent from CR/LF line endings and leading/traiing spaces#344dmk978 wants to merge 3 commits intorust-db:mainfrom
dmk978 wants to merge 3 commits intorust-db:mainfrom
Conversation
…ling/leading spaces.
Author
|
Currently SQL migration code is treated as binary files, which is really inconvenient for source tracking. As text files often differ in line endings and sometimes leading tabs/spaces, I think it makes sense to make hash code independent from that small and irrelevant changes. But, of course, it will break compatibility with previous versions. |
jxs
reviewed
Jul 26, 2025
Member
jxs
left a comment
jxs
left a comment
There was a problem hiding this comment.
Hi, sorry for the delay and thanks for this!
Ideally this makes sense, but this will break refinery for everyone who's already using it, wdyt of feature gating it? Can you also solve CI issues?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.