Render ambiguous width emoji always full-width#840
Draft
tompng wants to merge 1 commit intoruby:masterfrom
Draft
Render ambiguous width emoji always full-width#840tompng wants to merge 1 commit intoruby:masterfrom
tompng wants to merge 1 commit intoruby:masterfrom
Conversation
Some emoji such as flag emoji and Extended_Pictographic followed by variation-selector-16 are rendered in half-width or full-width depend on terminal emulator and its configuration. Adds a special rendering flow to always render these character in full-width.
1776644 to
f661675
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This ambiguous is not about EastAsianWidth.
Width of some emoji such as 🇯🇵(Flag emoji) and ©️(Extended_Pictographic + Variation_Selector_16) are ambiguous.
It depends on terminal emulator and its configuration.
For example, iTerm has "Flag emoji render full-width: Yes/No" and "Support variation selector 16 making emoji fullwidth" configuration.
This pull request renders these ambiguous width emoji always in full-width by this step.
" "to clear text and backgroundHere's an example.