Skip to content

User shortName instead of substring on sha copy#427

Open
mczepiel wants to merge 1 commit intorowanj:masterfrom
mczepiel:sha_copy
Open

User shortName instead of substring on sha copy#427
mczepiel wants to merge 1 commit intorowanj:masterfrom
mczepiel:sha_copy

Conversation

@mczepiel
Copy link

Nothing functionally different, just using what the commit offers. In the process of some other changes locally.

@mczepiel
Copy link
Author

FWIW it looks like shortName will always return a SHA, so this is functionally equivalent to the manual substring:

- (NSString *) shortName
{
    return self.gtCommit.shortSHA;
}

So this should be fine so long as we're alwasy dealing with commits and not refs, which have a different shortName behavior:
// shortName a more user friendly version of the refName, "master" or a short SHA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant