Open
Conversation
Conflicts: MGScopeBar
Visual changes:
* Use a more structured table layout for the list of files.
Obj-C Code changes:
* Load the diffstat info with:
$ git show --numstat -M --summary --pretty=raw $REV
and then (as a 2nd, separate NSTask) load the full diff, with:
$ git show --pretty=raw -M --no-color $REV
* A side-effect of this is that you now get a list of files changed in a
merge commit, whereas it used to only show the commit message.
Javascript/HTML code changes:
* Get the commit view header info from the first task, so it should load
quicker, especially for commits with really long diffs.
* Use the --numstat info (from the output of the first NSTask) to get the
full list of files changed and the number of changed lines in each, and
the --summary info to see if any files were created/deleted.
* Add a "prototype" of the file-list element in index.html, and then have the
javascript extract then clone that, rather than building the elements
totally in code.
* Add javascript functions to show/hide the lines added/removed details when
the mouse hovers over the lines changed summary.
Conflicts:
Classes/Controllers/PBWebHistoryController.m
MGScopeBar
html/views/history/history.css
html/views/history/history.js
html/views/history/index.html
Also, better handle filenames with spaces Conflicts: MGScopeBar
* Made the border color match the file diffs. * Made the background color lighter and the text darker, so it's easier to read (and doesn't have the slight look of being disabled that it used to have). * Changed the text shadow on the file names so it doesn't looks weird when overlapping a graph bar. In fact, now it helps readability in that case. Conflicts: MGScopeBar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a nice addition by "kelan" that I find useful. It shows diffstat info for each commit. It's especially useful for "large" commits, because it shows a summary of what's been changed. I've simply cherry-picked his changes to your recent version.