Open
Conversation
added 4 commits
July 3, 2013 19:45
Typical error message might be "Bad credentials"
ssp
pushed a commit
to ssp/gitx
that referenced
this pull request
May 23, 2021
Bump Sparkle to latest master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not especially pretty, but how about something like this?
It now pulls your access token from NSUserDefaults rather than the git config. Possibly
-[PBWebHistoryController getConfig:]could be removed now, nothing else is using it.It could be argued that the access token ought to be stored in keychain rather than NSUserDefaults, though the current behaviour is no worse than storing it in .gitconfig ...