Skip to content

Fix rhel10 flake8 problems#248

Open
InvincibleRMC wants to merge 6 commits intoros2:rollingfrom
InvincibleRMC:rhel10-flake8
Open

Fix rhel10 flake8 problems#248
InvincibleRMC wants to merge 6 commits intoros2:rollingfrom
InvincibleRMC:rhel10-flake8

Conversation

@InvincibleRMC
Copy link
Contributor

@InvincibleRMC InvincibleRMC commented Feb 4, 2026

Description

Fixes rhel10 flake8 errors.
https://ci.ros2.org/job/test_ci_linux-rhel/156/
TLDR;
flake8-import-order now checks inside of TYPE_CHECKING blocks.

Is this user-facing behavior change?

Did you use Generative AI?

Additional Information

Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Copy link
Contributor Author

Pulls: #248
Gist: https://gist.githubusercontent.com/InvincibleRMC/c2bca386bdb71d3cc666046bcc8d1c70/raw/2e0c8ddbe88d166eecacce0f0cf951e7346c85b7/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rosidl_generator_py
TEST args: --packages-above rosidl_generator_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18115

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
Copy link
Contributor Author

Pulls: #248
Gist: https://gist.githubusercontent.com/InvincibleRMC/2b0202e306c426d2b44f137d0bc39373/raw/2e0c8ddbe88d166eecacce0f0cf951e7346c85b7/ros2.repos
BUILD args: --event-handlers console_cohesion+ --retest-until-pass 2 --ctest-args -LE "(xfail|uncrustify)" --pytest-args -m "not xfail" --packages-skip-by-dep qt_gui_cpp --packages-skip qt_gui_cpp --packages-above-and-dependencies rosidl_generator_py
TEST args: --packages-above rosidl_generator_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18122

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC InvincibleRMC changed the title rhel10 flake8 Fix rhel10 flake8 problems Feb 6, 2026
@InvincibleRMC
Copy link
Contributor Author

InvincibleRMC commented Feb 6, 2026

Pulls: #248
Gist: https://gist.githubusercontent.com/InvincibleRMC/2521e884220a8513fba61021a62856c3/raw/2e0c8ddbe88d166eecacce0f0cf951e7346c85b7/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rosidl_generator_py
TEST args: --packages-above rosidl_generator_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18139

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Rhel 10 job
https://ci.ros2.org/job/test_ci_linux-rhel/156/

@InvincibleRMC InvincibleRMC marked this pull request as ready for review February 6, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant