Throttle not launching in non-composed mode#101
Open
papertowel123 wants to merge 2 commits intoros-tooling:ironfrom
Open
Throttle not launching in non-composed mode#101papertowel123 wants to merge 2 commits intoros-tooling:ironfrom
papertowel123 wants to merge 2 commits intoros-tooling:ironfrom
Conversation
Signed-off-by: maksymdidukh <maxym.didukh@logivations.com>
1c20751 to
ecc7e1b
Compare
Signed-off-by: maksymdidukh <maxym.didukh@logivations.com>
|
This also works if you need a temporary fix: Node( |
Author
Thanks, but we already merged the PR into our fork, so no need for temporary fix)) |
Member
MichaelOrlov
left a comment
There was a problem hiding this comment.
@maksymdidukh The change looks pretty trivial. Allowing to start with no CLI arguments by default.
However, I am curious what will be the default configuration for throttle in this case?
Will not it cause undefined behaviour?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change:
Here is a part of a launch file, where we trying to launch throttle as a node:
yaml:
We face this error while executing the launch file:

Changes in this PR:
main()Results:
ros2 topic echo /odometry/filtered