Fix minor error in amcl.launch#39
Merged
fjp merged 1 commit intoros-mobile-robots:noetic-develfrom Sep 22, 2021
Merged
Conversation
The "kld_err" is initialized twice, and with the wrong values. I guess you wanted to initialize the "kld_error" parameter to 0.01 and "kld_z" to 0.99.
Contributor
Author
|
In fact I don't even know how you performed the localization with amcl correctly using that configuration (kld_err=kld_z=0.99). |
Member
I think the The odometry sensors I use (encoders in the DG01D-E motors) are definitely not precise ;-) I hope to find more time soon to improve odometry and work on #37 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The "kld_err" is initialized twice, and with the wrong values.
I guess you wanted to initialize the "kld_err" parameter to 0.01 and "kld_z" to 0.99.