Updates following usage in another project#2
Open
robinpaulson wants to merge 1 commit intorobinpaulson:masterfrom
MrHarcombe:master
Open
Updates following usage in another project#2robinpaulson wants to merge 1 commit intorobinpaulson:masterfrom MrHarcombe:master
robinpaulson wants to merge 1 commit intorobinpaulson:masterfrom
MrHarcombe:master
Conversation
Owner
robinpaulson
commented
Oct 28, 2021
robinpaulson
commented
- added 'parallactic angle' to getMoonPosition returned values
- added 'solar noon' and 'nadir' to getTimes returned values
- added optional height parameter to getTimes
- testing for getMoonTimes has had to change from the JavaScript implementation, as can't find any difference in code but getting minor difference in output
- added 'solar noon' and 'nadir' to getTimes returned values - added optional height parameter to getTimes - testing for getMoonTimes has had to change from the JavaScript implementation, as can't find any difference in code but getting minor difference in output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.