Implicitly marking parameter $previous as nullable is deprecated

[okorneliuk]

Q	A
Bugfix?	✔️
Issue	roadrunner-php/issues#39

PHP 8.4
Deprecated: Spiral\RoadRunner\GRPC\Exception\GRPCException::create(): Implicitly marking parameter $previous as nullable is deprecated, the explicit nullable type must be used instead

Summary by CodeRabbit

• Bug Fixes
  • Updated exception handling to improve type safety by making the $previous parameter explicitly nullable in the GRPCException class.

[coderabbitai]

Walkthrough

The pull request introduces a minor type modification to the GRPCException class in the src/Exception/GRPCException.php file. The change involves explicitly marking the $previous parameter as nullable in both the constructor and the static create method by adding a ? before the \Throwable type hint. This adjustment clarifies the parameter's optional nature without altering the core functionality of the exception handling mechanism.

Changes

File	Change Summary
src/Exception/GRPCException.php	Updated method signatures to explicitly allow nullable \Throwable for $previous parameter in constructor and create method

Poem

🐰 A Rabbit's Nullable Tale 🐰

In exceptions where errors might hide,
A question mark now sits with pride
Nullable types, so clear and bright
Making our code's intent just right!
A tiny change, yet oh so neat

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 49f1ae1 and 4bcc87b.

📒 Files selected for processing (1)

• src/Exception/GRPCException.php (2 hunks)

🔇 Additional comments (2)

src/Exception/GRPCException.php (2)

33-33: Explicitly marking $previous as nullable is correct and aligns with PHP 8.4.
No issues here. This change properly indicates that the $previous parameter can be null, preventing deprecation warnings.

---

47-47: Ensuring consistency in parameter nullability across factory method.
This matches the change in the constructor and avoids any potential type mismatch.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.