Skip to content

Conversation

@cknitt
Copy link
Member

@cknitt cknitt commented Jan 21, 2026

  • Removes the deprecated module systems es6 and es6-global (superseded by esmodule)
  • Adds proper validation of module systems to rewatch
  • Removes unused stuff from Ext_path

Supersedes #8130

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 21, 2026

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@8205

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@8205

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@8205

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@8205

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@8205

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@8205

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@8205

commit: a1924ee

@cknitt cknitt changed the title Remove module variants es6 and es6-global Remove deprecated module systems es6 and es6-global Jan 21, 2026
@cknitt cknitt requested review from cristianoc, nojaf and zth January 21, 2026 08:36
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.
In the error message when a legacy mode is used, perhaps suggest what to use instead.

@cknitt
Copy link
Member Author

cknitt commented Jan 21, 2026

Great. In the error message when a legacy mode is used, perhaps suggest what to use instead.

I don't know, the corresponding deprecation warning with migration instructions was already in v12.

Now there is no special handling anymore, and the error says

"Module system \"{other}\" is unsupported. Expected \"commonjs\" or \"esmodule\"."

It should still be clear enough what to migrate to from "es6" even if one skipped v12.

@cknitt cknitt enabled auto-merge (squash) January 21, 2026 09:00
@cknitt cknitt merged commit 3f0b49a into rescript-lang:master Jan 21, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants