Skip to content

fix: remove commonjs require from jest/setup for document picker #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mlisikbf wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: remove commonjs require from jest/setup for document picker #916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7f26b6
fix: remove commonjs require from jest/setup for document picker
mlisikbf Jan 20, 2026
559df82
adds changeset
mlisikbf Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sharp-days-sort.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@react-native-documents/picker': patch
---

fix: jest setup warnings from trying to reading commonjs module
5 changes: 1 addition & 4 deletions packages/document-picker/jest/setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,7 @@ function mockFactory() {
jest.mock('../src/spec/NativeDocumentPicker', () => mockFactory())
// the following are for jest testing outside of the library, where the paths are different
// alternative is to use moduleNameMapper in user space
const mockModulePaths = [
'../../../lib/commonjs/spec/NativeDocumentPicker',
'../../../lib/module/spec/NativeDocumentPicker',
]
const mockModulePaths = ['../../../lib/module/spec/NativeDocumentPicker']
mockModulePaths.forEach((path) => {
try {
require.resolve(path)
Expand Down