fix(TextBox): update Text patching to allow for proper dimension setting and text centering#463
Draft
ImCoolNowRight wants to merge 3 commits intodevelopfrom
Draft
fix(TextBox): update Text patching to allow for proper dimension setting and text centering#463ImCoolNowRight wants to merge 3 commits intodevelopfrom
ImCoolNowRight wants to merge 3 commits intodevelopfrom
Conversation
Collaborator
|
Test Execution Failed. |
ImCoolNowRight
force-pushed
the
fix/LUI-1324
branch
from
7ae9f29 to
64ec4be
Compare
Collaborator
|
Test Execution Failed. |
Collaborator
|
Test Execution Failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates how the patch object for the Text tag is created to ensure the tag can get the proper parent dimensions it needs in order to center text.
References
LUI-1324
Testing
In the TextBox story, add
textAlign: 'center'to thetextStyle. You should see that the text properly centers when you toggle the control forfixed.Automation
Checklist