Bug | onLaneScroll has to be called on scroll down at all zoom levels#458
Open
satya-imaginea wants to merge 1 commit intorcdexta:masterfrom
Open
Bug | onLaneScroll has to be called on scroll down at all zoom levels#458satya-imaginea wants to merge 1 commit intorcdexta:masterfrom
satya-imaginea wants to merge 1 commit intorcdexta:masterfrom
Conversation
I think I don't have permission to raise PR to this branch. Would you release this change, this should fix the 'onLaneScroll callback has not been triggered' issue permanently.
satya-imaginea
changed the title
satya-imaginea
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would you please release this change? this should fix the 'onLaneScroll callback has not been triggered' issue permanently.
At a certain zoom level we get minimum 1 as the element position. I tried with all zoom levels, hence this fix should trigger onLaneScroll callback properly in screens of different sizes and at different zoom levels.
your release will help me a lot with my project, thanks a lot for earlier responses.
@rcdexta @dapi @oliviervanbulck @yashutanna