Implement 004-mvp-hardening: secure credentials, access control, terminal package#3
Open
Implement 004-mvp-hardening: secure credentials, access control, terminal package#3
Conversation
…inal package Phase 1-2: Setup & Foundational - Add bootstrap token types to shared package - Add D1 migration for errorReason, shutdownDeadline columns - Add cron trigger configuration in wrangler.toml Phase 3: Secure Credential Delivery (US1) - Add bootstrap service with one-time token generation - Add bootstrap route for VM token redemption - Implement AES-GCM encryption for credentials in KV - 5-minute TTL for bootstrap tokens Phase 4: Workspace Access Control (US2) - Add requireWorkspaceOwnership middleware - Return 404 (not 403) to prevent information disclosure - Add workspace ownership tests Phase 5: Provisioning Timeout (US3) - Add timeout service to detect stuck workspaces - Update workspace status to 'error' after 10 minutes - Add cron trigger for periodic timeout checks Phase 6: Shared Terminal Package (US6) - Create @simple-agent-manager/terminal package - Add Terminal component with xterm.js integration - Add useWebSocket hook with exponential backoff reconnection - Add useIdleDeadline hook for countdown display - Add StatusBar and ConnectionOverlay components Phase 7: WebSocket Reconnection (US4) - Integrate terminal package into web app - Add reconnection UI with retry button - Display connection state (connecting, connected, reconnecting, failed) Phase 8: Idle Deadline Display (US5) - Update Go idle detector to deadline-based tracking - Add GetDeadline() method with thread-safe access - Update heartbeat to include shutdownDeadline - Add shutdown deadline display in WorkspaceCard Phase 9: Polish - Update CLAUDE.md and README.md documentation - Fix lint errors across test files - Run security audit and coverage verification Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ng notes - Agents should use docs/notes/ for ephemeral working notes - All markdown files should be kebab-case (except README, LICENSE, etc.) - Never put documentation in package roots Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the 004-mvp-hardening feature with comprehensive security and UX improvements:
Test plan
pnpm lintpassespnpm typecheckpassespnpm testpasses (74 tests)pnpm buildsucceedsSecurity Notes
Security audit identified items for follow-up:
🤖 Generated with Claude Code