set timeout from constructor#253
Open
zjmarlow wants to merge 2 commits intoraku-community-modules:mainfrom
Open
set timeout from constructor#253zjmarlow wants to merge 2 commits intoraku-community-modules:mainfrom
zjmarlow wants to merge 2 commits intoraku-community-modules:mainfrom
Conversation
Author
|
I can commit tests to make sure the default is still in place and that the constructor accepts the timeout value. I tested them personally but it would be good to have the tests part of the test suite. |
Member
Yeah if you could stick a test in that would be great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #206