Need to sort url parameters, in V4 Signature#2
Open
barryhunter wants to merge 1 commit intoracklin:masterfrom
Open
Need to sort url parameters, in V4 Signature#2barryhunter wants to merge 1 commit intoracklin:masterfrom
barryhunter wants to merge 1 commit intoracklin:masterfrom
Conversation
Found this fork that adds V4 verification - which is great. But run into problem, found the URL params needs to be sorted (eg when runing ListObjects on a bucket, it adds multiple when using delimiter+prefix for example) https://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html Thought worth pushing this upstream. This is the same change made in our copy geograph-project/geograph-project@466592a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this fork that adds V4 verification - which is great.
But run into problem, found the URL params needs to be sorted (eg when runing ListObjects on a bucket, it adds multiple when using delimiter+prefix for example)
https://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html
Thought worth pushing this upstream.
This is the same change made in our copy geograph-project/geograph-project@466592a