-
Notifications
You must be signed in to change notification settings - Fork 49
Modify checkbox css to omit bullet/number and fix spacing #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking so much better for un-nested lists!
However, nested lists still exhibit some problems, similar to what is pointed out in #378 (comment):
Here is what I was using:
- [x] Ut enim ad minim veniam
- [ ] Quis nostrud exercitation ullamco laboris
- [ ] Nisi ut aliquip ex ea commodo consequat
- [ ] Duis aute irure dolorAre you going to address the nested lists with #378?
|
I did remove the bullets/numbers for nested lists. I think what you might be getting at is that it feels like a checkbox that contains a nested list should not be vertically-centered beside that list, rather it should be vertically align to the top. I'll try to address that. |
3aa395b to
3aff181
Compare
|
@juliasilge I've changed the vertical alignment of the checkboxes. Does this address what you are talking about? |
juliasilge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that looks great! 🙏

Fixes #378
Checkbox items no longer have bullets or numbers (if in an unordered list or ordered list respectively).
Note: Checkbox items in bulleted and numbered lists look identical now. This could be misleading because if all the items are checkbox-ed, you won't know if its a bulleted or numbered list. I think this is okay because its consistent with how markdown is usually rendered.