Cast inputs type to dictionary.#2585
Open
ostrowskimarcin wants to merge 1 commit intopytorch:mainfrom
Open
Conversation
Contributor
Author
1 similar comment
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run some tests of hf_clip model using torchbench.py (https://github.com/pytorch/pytorch/blob/main/benchmarks/dynamo/torchbench.py). This script at one point clones input data with custom function (https://github.com/pytorch/pytorch/blob/main/torch/_dynamo/utils.py, L1926):
hf_clip model generates example data using 'CLIPProcessor' class imported from transformers repo. We can use this data as a dictionary, but officialy its type is BatchEncoding (<class 'transformers.tokenization_utils_base.BatchEncoding'>). When clone_inputs() compares input types it doesn't see it as a dict type. Hence, it casts the data to list and returns only its keys leading to error: AttributeError: 'str' object has no attribute 'shape'
I proposed simple casting to dict in model's init script. This fixed the issue and doesn't affect other test scripts.