Skip to content

gh-144048: Use flexible array members #144049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AZero13 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

gh-144048: Use flexible array members #144049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Include/cpython/pystate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
struct _stack_chunk *previous;
size_t size;
size_t top;
PyObject * data[1]; /* Variable sized */
PyObject * data[];

Check warning on line 61 in Include/cpython/pystate.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (x64) 

nonstandard extension used: zero-sized array in struct/union [D:\a\cpython\cpython\PCbuild\pythonw_uwp.vcxproj]

Check warning on line 61 in Include/cpython/pystate.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (x64) 

nonstandard extension used: zero-sized array in struct/union [D:\a\cpython\cpython\PCbuild\python_uwp.vcxproj]

Check warning on line 61 in Include/cpython/pystate.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (x64) 

nonstandard extension used: zero-sized array in struct/union [D:\a\cpython\cpython\PCbuild\_wmi.vcxproj]

Check warning on line 61 in Include/cpython/pystate.h

View workflow job for this annotation

GitHub Actions / Windows / Build and test (arm64) 

nonstandard extension used: zero-sized array in struct/union [C:\a\cpython\cpython\PCbuild\pythonw_uwp.vcxproj]

Check warning on line 61 in Include/cpython/pystate.h

View workflow job for this annotation

GitHub Actions / Windows / Build and test (arm64) 

nonstandard extension used: zero-sized array in struct/union [C:\a\cpython\cpython\PCbuild\python_uwp.vcxproj]

Check warning on line 61 in Include/cpython/pystate.h

View workflow job for this annotation

GitHub Actions / Windows / Build and test (arm64) 

nonstandard extension used: zero-sized array in struct/union [C:\a\cpython\cpython\PCbuild\_wmi.vcxproj]

Check warning on line 61 in Include/cpython/pystate.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (arm64) 

nonstandard extension used: zero-sized array in struct/union [C:\a\cpython\cpython\PCbuild\pythonw_uwp.vcxproj]

Check warning on line 61 in Include/cpython/pystate.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (arm64) 

nonstandard extension used: zero-sized array in struct/union [C:\a\cpython\cpython\PCbuild\python_uwp.vcxproj]

Check warning on line 61 in Include/cpython/pystate.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (arm64) 

nonstandard extension used: zero-sized array in struct/union [C:\a\cpython\cpython\PCbuild\_wmi.vcxproj]

Check warning on line 61 in Include/cpython/pystate.h

View workflow job for this annotation

GitHub Actions / Windows / Build and test (x64) 

nonstandard extension used: zero-sized array in struct/union [D:\a\cpython\cpython\PCbuild\pythonw_uwp.vcxproj]

Check warning on line 61 in Include/cpython/pystate.h

View workflow job for this annotation

GitHub Actions / Windows / Build and test (x64) 

nonstandard extension used: zero-sized array in struct/union [D:\a\cpython\cpython\PCbuild\python_uwp.vcxproj]

Check warning on line 61 in Include/cpython/pystate.h

View workflow job for this annotation

GitHub Actions / Windows / Build and test (x64) 

nonstandard extension used: zero-sized array in struct/union [D:\a\cpython\cpython\PCbuild\_wmi.vcxproj]
Copy link
Member

@vstinner vstinner Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid flexible array in the public C API (_PyStackChunk in Include/cpython/pystate.h): revert this change.

} _PyStackChunk;

/* Minimum size of data stack chunk */
Expand Down
2 changes: 1 addition & 1 deletion Modules/_sre/sre.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ typedef struct {
struct {
Py_ssize_t index;
PyObject *literal; /* NULL if empty */
} items[0];
} items[];
} TemplateObject;

typedef struct SRE_REPEAT_T {
Expand Down
2 changes: 1 addition & 1 deletion Objects/memoryobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,7 +1042,7 @@ memoryview__from_flags_impl(PyTypeObject *type, PyObject *object, int flags)

typedef struct {
Py_buffer view;
Py_ssize_t array[1];
Py_ssize_t array[];
} Py_buffer_full;

int
Expand Down
Loading