gh-143959 make test_sys import _datetime inside the test #144003
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lib/test/test_sys.py
Outdated
| self.assertEqual(sys.getsizeof(True, -1), size('') + self.longdigit) | ||
|
|
||
| def test_objecttypes(self): | ||
| import _datetime |
Member
There was a problem hiding this comment.
I suggest to import it just before it is used, like collections.
And since it is optional, skip the corresponding test if the import fails.
Contributor
Author
There was a problem hiding this comment.
Thanks! Fixed it
Member
There was a problem hiding this comment.
And since it is optional, skip the corresponding test if the import fails.
_datetime is now a built-in module, it's not really optional.
Member
There was a problem hiding this comment.
Isn't it just an implementation detail? It was made builtin to solve a particular technical issue which can be solved in other way.
serhiy-storchaka
added
needs backport to 3.13
vstinner
reviewed
Jan 21, 2026
| check(x, size('5Pi')) | ||
| # PyCapsule | ||
| import _datetime | ||
| check(_datetime.datetime_CAPI, size('6P')) |
Member
There was a problem hiding this comment.
As @serhiy-storchaka requested, this line should only be run if _datetime is available. Something like:
try:
import _datetime
except ImportError:
pass
else:
check(_datetime.datetime_CAPI, size('6P'))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_datetimedependency oftest_sysis only required for@cpython_onlydecorated test.