gh-143504: Expose CELL status of a symbol in symtable (GH-143504) #143549
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yashp002
changed the title
aisk
reviewed
Jan 8, 2026
Co-authored-by: AN Long <aisk@users.noreply.github.com>
Contributor
Author
|
I'll fix this in a while, my apologies for quite a big fault in the code actually |
iritkatriel
reviewed
Jan 21, 2026
Lib/test/test_symtable.py
Outdated
| outer = find_block(top, "outer") | ||
| self.assertIn("x",outer.get_cells()) | ||
| self.assertTrue(outer.lookup("x").is_cell()) | ||
| self.assertFalse(outer.lookup("inner").is_cell()) |
Member
There was a problem hiding this comment.
Let's put this test next to test_free.
iritkatriel
reviewed
Jan 21, 2026
Lib/symtable.py
Outdated
| __frees = None | ||
| __globals = None | ||
| __nonlocals = None | ||
| __cells = None |
Contributor
Author
There was a problem hiding this comment.
No, I was using it for another version of the code which didn't end up working out, I'll be removing it now.
iritkatriel
reviewed
Jan 21, 2026
Lib/symtable.py
Outdated
|
|
||
| def get_cells(self): | ||
| """Return a list of cell variable names in the table.""" | ||
| return [s.get_name() for s in self.get_symbols() if s.is_cell()] |
Member
There was a problem hiding this comment.
This probably belongs next to get_frees.
Contributor
Author
|
@iritkatriel I was forced to force push the symtable branch due to me updating the branch before for the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose cell status in symtable.Symbol via new
is_cell()predicate and addget_cells()method to SymbolTable.Changes
Symbol.is_cell()method that returnsTrueif the symbol has the CELL flag.SymbolTable.get_cells()method that returns an iterable of cell variable names.test_cellstoLib/test/test_symtable.pyto verify the new API.Tests
test_cellstest using a closure pattern (outer -> inneraccessingx).