Open
Conversation
Owner
|
Hi, I'm not familiar yet with pyproject.toml. i read a bit and it seems indeed encoyraged by the Python team themselves. Right now CI is failing, so I can't merge. Ideally, a change request should come with some explanation. Random PR with no context are not so appealing for a maintainer. I had to validate you were not some bots or student trying to get internet points with automated PR. |
Owner
|
CI failure seems due to the fact that pyproject.toml requires a newer version of python. Not sure I am ready to drop backward compatibility for no gain other than using the latest style. As long as setup.py is supported by newer versions, I would play it conservative |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.