fixed deps git protocol

[jywarren]

No description provided.

[jywarren]

Lets upgrade editor to 3.1.0 to resolve:

inline-markdown-editor/package-lock.json

Line 4947 in 12b3d1a

"woofmark": "git://github.com/jywarren/woofmark.git#plots2",

[jywarren]

Hmm... ok its very close to this issue: actions/setup-node#214

[jywarren]

a5ccf9a resulted in an endless loop of tests oddly. Trying node 16 instead...

[jywarren]

node 16 worked but went into endless test loop.

[jywarren]

Solved recursive issue. Now getting:

12 specs in 0.[31](https://github.com/publiclab/inline-markdown-editor/runs/5602541469?check_suite_focus=true#step:7:31)4s.
>> 0 failures
Fatal error: Callback must be a function. Received undefined�
Error: Process completed with exit code 3.

Prev this didn't happen:

https://github.com/publiclab/inline-markdown-editor/runs/2969361193?check_suite_focus=true

[jywarren]

Unfortunately i think we may have an incorrectly written function somewhere in out tests? I'm not sure. Compare to similar error in this: https://stackoverflow.com/questions/36514468/jasmine-throws-one-error-error-timeout-async-callback-was-not-invoked#36514646

[jywarren]

Noting that in plots2:

However I'm not seeing this error in other recent plots2 PRs... very strange. So maybe we can drop this for now?

publiclab/plots2#10768 (comment)

[TildaDares]

@jywarren Can you try adding a callback done to this function and calling it?

inline-markdown-editor/spec/javascripts/replacement_spec.js

Line 3 in 12b3d1a

it("won't generate an editor for an ambiguous (duplicated) section, where replacement server side could apply to the wrong section", function() {

[jywarren]

@jywarren Can you try adding a callback done to this function and calling it?

inline-markdown-editor/spec/javascripts/replacement_spec.js

Line 3 in 12b3d1a

it("won't generate an editor for an ambiguous (duplicated) section, where replacement server side could apply to the wrong section", function() {

Thank you I'll try that!

[jywarren]

Hmm, i don't know why the Github Actions CI run isn't going, but i tried it manually in gitpod and got:

12 specs in 0.002s.
>> 0 failures
Fatal error: Callback must be a function. Received undefined

... so same issue. This is lower priority now but pretty annoying!

[TildaDares]

@jywarren You didn’t add the done callback to the function declaration on line 3.

[jywarren]

@TildaDares didn't i add it here? Or did I miss somewhere else too?

[TildaDares]

Oh sorry I didn’t see that😅

[jywarren]

Just noting that we're getting a recursive loop of the tests running. Maybe we can search for this kind of error in the Jasmine forums or on StackOverflow.