Add macOS Framework build support #957
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ENABLE_MACOS_FRAMEWORK cmake option to build projectM-4.framework and projectM-4-playlist.framework bundles instead of plain dylibs. Only available on macOS with shared library builds. The frameworks include all public headers in the Headers/ directory and use standard macOS framework versioning (Version A). Fixes #924
- Use absolute paths for headers exported to parent scope - Include C++ headers in framework when ENABLE_CXX_INTERFACE is on
revmischa
force-pushed
the
feature/macos-framework-924
branch
from
06a84aa to
cce5fdd
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds opt-in support for building libprojectM and the playlist library as macOS Framework bundles through a new ENABLE_MACOS_FRAMEWORK CMake option. This addresses issue #924 by enabling developers to build .framework outputs suitable for macOS application integration.
Changes:
- Added
ENABLE_MACOS_FRAMEWORKCMake option to enable framework builds on Darwin platforms with shared libraries - Modified header paths in API configuration to use absolute paths for proper framework header handling
- Added framework build configuration for both projectM and projectM_playlist libraries
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CMakeLists.txt | Adds ENABLE_MACOS_FRAMEWORK cmake option and status output |
| src/api/CMakeLists.txt | Converts header paths to absolute paths and exports PROJECTM_PUBLIC_HEADERS to parent scope for framework builds |
| src/libprojectM/CMakeLists.txt | Configures projectM as a framework bundle with proper identifiers and headers, updates install destination path |
| src/playlist/CMakeLists.txt | Configures projectM_playlist as a framework bundle with proper identifiers and install destinations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an opt-in CMake path to build libprojectM and the playlist library as macOS Framework bundles to simplify integration with macOS apps expecting .framework outputs.
Fixes #924