Open
Conversation
Collaborator
Author
|
MyPage 상단 설정 버튼에 데이터 초기화 함수를 임시로 적용해놓았습니다 . . ! |
hyunjung-choi
changed the title
Member
|
이 PR을 먼저 검토하고, #14 는 이 브랜치에서 설정한 Hilt 설정으로 마이그레이션할게요. |
gdaegeun539
requested changes
Jan 21, 2026
Member
gdaegeun539
left a comment
gdaegeun539
left a comment
There was a problem hiding this comment.
이거만 먼저 커멘트 부탁드립니다. 나머지 부분은 계속 코드리뷰 진행할게요.
Member
|
기능상으로는 잘 되는듯 보이는데 레이어 상으로 뭔가 애매한듯해서 오늘 퇴근하고 마저 커멘트 남길게요. |
gdaegeun539
requested changes
Jan 25, 2026
Member
gdaegeun539
left a comment
gdaegeun539
left a comment
There was a problem hiding this comment.
작동도 잘 되고 구현 감사합니다...만 여쭤보고 싶은 점이 있어요
| startDestination = FeelinDestination.Login.route, | ||
| route = FeelinDestination.OnboardingGraph.route | ||
| ) { | ||
| loginScreen(navController) |
Member
There was a problem hiding this comment.
오 이건 나중에 다른 화면들도 뎁스가 늘어나면 private 함수로 나누는걸 고려할 수 있겠네요 👍
| import kotlinx.coroutines.flow.first | ||
| import kotlinx.coroutines.launch | ||
|
|
||
| @Suppress("UnusedPrivateProperty") // TODO(@이대근): 실제 기능 구현시 제거할 것 2025.11.21. |
Member
There was a problem hiding this comment.
이거 어노테이션이랑 안쓰는 더미데이터 제가 떼서 올려도 괜찮을까요 🤔
|
|
||
| @HiltViewModel | ||
| class OnboardingViewModel @Inject constructor( | ||
| private val userPreferencesDataStore: UserPreferencesDataStore |
Member
There was a problem hiding this comment.
뷰모델에서 데이터소스를 바로 받아서 써도 괜찮을까요?
임시 로컬 저장소여서 나중에 서버 데이터와 연동하면 레포지토리 기반으로 전환하나요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior if this is a feature change?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
ScreenShots (If needed)