Handle documentation installation separate from binary installation.#245
Open
okeuday wants to merge 1 commit intoprocessone:developfrom
Open
Handle documentation installation separate from binary installation.#245okeuday wants to merge 1 commit intoprocessone:developfrom
okeuday wants to merge 1 commit intoprocessone:developfrom
Conversation
Collaborator
|
This looks simple and straight forward enough. What do you think @nniclausse? |
Collaborator
|
The change looks okay to me, but I'm not sure how your release process works and if this change interferes with that. Can you have a quick look, @nniclausse? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is basic/small, though you may want to handle the makefile dependencies in a different way (this is just the simple approach that doesn't break anything). The reason for this change, is to make sure tsung can be packaged easily, so there is clear delineation between documentation and binary installation files and makefile targets.