pdfHtml5 button causes exception.#5
Open
davimack wants to merge 2 commits intoprocessedbeets:masterfrom
Open
Conversation
Line 740, removed:
, { extend: 'pdfHtml5', orientation: 'landscape' }
Uncaught Cannot extend unknown button type: pdfHtml5
I suspect this is an underlying change to DataTables.
Adding to the search criteria for the dropdowns, as it's failing in some instances - seems to be going with a regular search, wherein it'll pull all words rather than an exact phrase. E.g. "C78 abc 7" and "C78 abc 8" will always return both, as they match 7 and 8, C, and abc.
Contributor
Author
|
Getting rid of pdfHtml5 button as it causes exceptions. Adding additional parameters to column search as something's changed somewhere & they no longer performed an exact search, but a "smart" search for all space-separated terms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if I could have just plugged in the button by name rather than removing the extension altogether, but....
Line 740, removed:
, { extend: 'pdfHtml5', orientation: 'landscape' }
Uncaught Cannot extend unknown button type: pdfHtml5
I suspect this is an underlying change to DataTables.