Move some inline functions from the header to the cpp file because of…#18
Open
0ric1 wants to merge 1 commit intoppescher:masterfrom
0ric1:MoveInlineFunctions
Open
Move some inline functions from the header to the cpp file because of…#180ric1 wants to merge 1 commit intoppescher:masterfrom 0ric1:MoveInlineFunctions
0ric1 wants to merge 1 commit intoppescher:masterfrom
0ric1:MoveInlineFunctions
Conversation
Owner
|
I don't see anything wrong with making all class member functions non inline and move them to the .cpp file. However there are other classes that would need similar changes, which are not present in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… linker errors when using ResizableLib as dll, see Issue #17 #17