Enhances 'spo site hubsite' commands with admin permissions#7101
Open
milanholemans wants to merge 1 commit intopnp:mainfrom
Open
Enhances 'spo site hubsite' commands with admin permissions#7101milanholemans wants to merge 1 commit intopnp:mainfrom
milanholemans wants to merge 1 commit intopnp:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request enhances the spo site hubsite connect and spo site hubsite disconnect commands by adding an --asAdmin option that allows SharePoint administrators to perform these operations using tenant admin APIs. The PR also migrates both commands from the legacy options/validators pattern to the modern Zod schema validation pattern.
Changes:
- Added
--asAdminoption to enable hub site connection/disconnection operations as a SharePoint administrator - Migrated both commands from legacy validation to Zod schema validation
- Updated tests to use schema-based validation and added test coverage for the new asAdmin functionality
- Enhanced documentation with permissions tables and examples demonstrating the new asAdmin option
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| site-hubsite-disconnect.ts | Migrated to Zod schema validation and added asAdmin option to use tenant admin API endpoint |
| site-hubsite-disconnect.spec.ts | Updated tests to use schema validation and added test for asAdmin functionality |
| site-hubsite-connect.ts | Migrated to Zod schema validation and added asAdmin option to use tenant admin API endpoint |
| site-hubsite-connect.spec.ts | Updated tests to use schema validation and added test for asAdmin functionality |
| site-hubsite-disconnect.mdx | Added documentation for asAdmin option, permissions table, and usage example |
| site-hubsite-connect.mdx | Added documentation for asAdmin option, permissions table, and usage example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5970