Conversation
|
@milanholemans I’ve added a Permissions section for all M365 Entra user commands in this PR: #6973. Could you please review it when you get a chance? |
|
We'll try to review it ASAP! Thx |
There was a problem hiding this comment.
Pull Request Overview
This pull request adds comprehensive Permissions sections to all m365 entra user commands documentation, standardizing the format to include both Delegated and Application permission types where applicable. The change enhances the documentation by clearly specifying the Microsoft Graph permissions required for each command.
Key changes:
- Added Permissions sections for all six
m365 entra usercommands - Used special formatting for the
user-hibpcommand since it uses Have I Been Pwned API instead of Microsoft Graph - Maintained consistent table format with permission types and required permissions
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/docs/cmd/entra/user/user-add.mdx | Added permissions table for user creation (User.ReadWrite.All) |
| docs/docs/cmd/entra/user/user-get.mdx | Added permissions table for user retrieval (User.Read.All) |
| docs/docs/cmd/entra/user/user-hibp.mdx | Added special permissions note for Have I Been Pwned API usage |
| docs/docs/cmd/entra/user/user-list.mdx | Added permissions table for user listing (User.Read.All, Directory.Read.All) |
| docs/docs/cmd/entra/user/user-remove.mdx | Added permissions table for user deletion (User.ReadWrite.All) |
| docs/docs/cmd/entra/user/user-set.mdx | Added permissions table for user updates (User.ReadWrite.All, Directory.Read.All) |
| docs/docs/cmd/entra/enterpriseapp/enterpriseapp-add.mdx | Added permissions with tabbed format for enterprise app creation |
| docs/docs/cmd/entra/enterpriseapp/enterpriseapp-get.mdx | Added permissions with tabbed format for enterprise app retrieval |
| docs/docs/cmd/entra/enterpriseapp/enterpriseapp-list.mdx | Added permissions with tabbed format for enterprise app listing |
| docs/docs/cmd/entra/enterpriseapp/enterpriseapp-remove.mdx | Added permissions with tabbed format for enterprise app deletion |
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
I just did a quick global review and noticed that you started great by adding the permissions table, but suddenly you changed the entire layout of the permissions table halfway. Is there a reason why you did this?
Please follow the instructions in the issue carefully.
|
@santhosh-7777, the tables are still not aligned. Please check the resources listed in the issue to properly create a permissions table. |
|
@milanholemans i have aligned properly for all .please review it? |
|
The permission section still doesn't comply with the instructions that are listed in the issue. For the last time, please carefully read the resources listed in the issue and align this PR accordingly. Some document pages are compliant, but most are not. |
|
Hey @santhosh-7777, would you be able to find some time to take a look at the remarks left here? |
3 participants
This pull request adds a Permissions section for all
m365 entra usercommands:m365 entra user addm365 entra user getm365 entra user hibpm365 entra user listm365 entra user removem365 entra user setSections are placed above the Examples section, include only supported auth types (Delegated and Application where applicable), and follow the existing docs formatting style.
order of Resources is alphabetical where multiple resources are present.
Closes #6952