Merge upstream #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: #431
as we need to know the floatsize to get the linker flags on Windows
they are nowhere used (it's all in GEM_RTE_CFLAGS), which breeds confusion as to where preprocessor flags and the like should go
rather than hardcoding Gem.dll
this is mainly useful for the windows builds (otherwise both use .dll)
but only for macOS and Windows. On Linux, this would pull in the whole world, among them the openGL-, X11-, wayland-, and SDL-(including pulse-) stacks.
e.g. "gem_imageSTB.so" -> "gem_imageSTB.amd64.so" the plugin-loader doesn't care about the actual extension, so we can use this to make plugins-coinstallable.
the buffer is really imagesize*xsize, rather than *ysize... Closes: #501
- it doesn't require the 'lod' parameter (for nvidia) - it does require openGL-3.0 (#version130) Closes: #505
- quality - repeat They are usually useless since a framebuffer is send to a texture, this flag can be set on the corresponding texture. however, when using the texunit message, this framebuffer can be accesed directlly from a shader. In this situation this flag should be set directlly in the framebuffer. a 3rd message is added : -clear it allow to disable the gl_clear function (color and depth buffer) This is usefull to add remanence to a buffer, without having to add an other (memory) buffer
by default, the object is not silent (e.g. in initFBO())
also, i think creating a window on load is rude.
- image width/height were swapped - final ROI height was wrongly calculated (x2-x1 in place of y2-y1)
Closes: #514 Co-authored-by: Ben Wesch <benjamin.wesch@gmail.com> Co-authored-by: IOhannes m zmölnig <zmoelnig@iem.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.