Implement SVG rendering of equations in dcc.Graph and dcc.Markdown using MathJax v3#1949
Merged
alexcjohnson merged 47 commits intodevfrom Mar 12, 2022
Merged
Implement SVG rendering of equations in dcc.Graph and dcc.Markdown using MathJax v3#1949alexcjohnson merged 47 commits intodevfrom
dcc.Graph and dcc.Markdown using MathJax v3#1949alexcjohnson merged 47 commits intodevfrom
Conversation
archmoj
commented
Feb 25, 2022
archmoj
commented
Feb 25, 2022
archmoj
commented
Feb 25, 2022
archmoj
commented
Feb 25, 2022
| inlineMath: props => ( | ||
| <Math tex={props.value} inline={true} /> | ||
| ), | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Thanks to @anders-kiaer for the contribution in 🏆 🏆 🏆 plotly/dash-core-components#634 🏆 🏆 🏆
alexcjohnson
reviewed
Mar 1, 2022
components/dash-core-components/tests/integration/markdown/test_markdown.py
Outdated
Show resolved
Hide resolved
alexcjohnson
reviewed
Mar 1, 2022
components/dash-core-components/tests/integration/markdown/test_markdown.py
Outdated
Show resolved
Hide resolved
alexcjohnson
reviewed
Mar 1, 2022
components/dash-core-components/tests/integration/markdown/test_markdown.py
Outdated
Show resolved
Hide resolved
alexcjohnson
reviewed
Mar 1, 2022
components/dash-core-components/tests/integration/graph/test_graph_varia.py
Outdated
Show resolved
Hide resolved
alexcjohnson
reviewed
Mar 1, 2022
components/dash-core-components/tests/integration/graph/test_graph_varia.py
Outdated
Show resolved
Hide resolved
alexcjohnson
reviewed
Mar 1, 2022
alexcjohnson
reviewed
Mar 1, 2022
alexcjohnson
reviewed
Mar 2, 2022
alexcjohnson
reviewed
Mar 2, 2022
…t_markdown.py Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
…t_markdown.py Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
…raph_varia.py Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
…t_markdown.py Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
…t_markdown.py Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
components/dash-core-components/tests/integration/markdown/test_markdown.py
Show resolved
Hide resolved
components/dash-core-components/tests/integration/markdown/test_markdown.py
Outdated
Show resolved
Hide resolved
components/dash-core-components/tests/integration/markdown/test_markdown.py
Show resolved
Hide resolved
components/dash-core-components/tests/integration/markdown/test_markdown.py
Show resolved
Hide resolved
…t_markdown.py Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
components/dash-core-components/src/utils/LazyLoader/mathjax.js
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@alexcjohnson How does the percy image test for MathJax look like? |
Collaborator
|
Looks good! Some parts of the graphs are grossly misaligned, but that's unfortunately normal for percy, we're missing some CSS from plotly.js |
alexcjohnson
approved these changes
Mar 12, 2022
Collaborator
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Fantastic work @archmoj!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Also bumping
plotly.jstov2.10.1.See additions and fixes in v2.10.0 and v2.10.1.
Example app: