Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new GitHub Actions workflow for creating "shadow releases" of the XELP branch. The workflow automatically calculates a modified version number (adding 100 to the major version), builds the project, and publishes it to a separate xelp/dist branch with an appropriate version tag.
- Creates versioned shadow releases from the
xelp/mainbranch - Automates version calculation with a unique naming scheme (major+100, with date and commit hash metadata)
- Builds and commits the distribution files to a dedicated branch with version tagging
16181fb to
d82e04c
Compare
6be2c3f to
374eba7
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/xelp_shadow_release.yml:1
- Array splitting logic can fail silently. When IFS='.' read splits the version string on line 38, if the version has fewer than 3 parts, the PARTS array will have fewer elements. Accessing ${PARTS[1]} or ${PARTS[2]} on lines 44-45 won't fail in bash but will result in empty strings, bypassing the check on line 39. This check should be performed immediately after the split, or use safer array access patterns. Move the validation block (lines 39-42) immediately after line 38, before any variable assignments.
name: Xelp Shadow Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.