Closed
Conversation
As now, for Composable Image (`stack`) we can define the Nix Channel in the `type` setting, we need to authorise having both `stack` and `type`
Update upsun.json
akalipetis
reviewed
Jun 25, 2025
Member
akalipetis
left a comment
akalipetis
left a comment
There was a problem hiding this comment.
Could you provide a couple of example in tests to validate this? Ideally, we want to ensure:
- if
stackexists, type starts withcomposable - update the failing test to include a
composabletype - add a new test to validate failure with a different type
Contributor
|
Sorry @flovntp @akalipetis I missed this PR and proposed #250 which does the same thing (apart from updating the test) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As now, for Composable Image (
stack) we can define the desired Nix Channel in thetypesetting, we need to authorise having bothstackandtype(and not one or the other)cf. platformsh/platformsh-docs#4623