fix: handle Express 5 req.params string | string[] union type #28
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Express 5 with @types/express@5.x types req.params values as string | string[] instead of just string. Update validateInteractionUid and sanitizeForLogging to accept the union type and normalize to string. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
validateInteractionUidin auth service to acceptstring | string[]parameter typesanitizeForLoggingin shared validation to acceptstring | string[]parameter typeContext
Express 5 with
@types/express@5.xchangedreq.paramsvalues fromstringtostring | string[]. This caused TypeScript build failures in the Docker build:Test plan
pnpm buildpassespnpm lintpasses🤖 Generated with Claude Code