fix(CLI): Fix creating projects from CLI with spaces in their name (SCD-52)#1042
Merged
BlumMichael merged 2 commits intomainfrom Feb 3, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where creating projects from the CLI with spaces in their names was not working correctly. The fix introduces a new Line function that properly handles user input by trimming whitespace, replacing the previous P function which used fmt.Scan and stopped reading at the first whitespace character.
Changes:
- Introduced a new
Linefunction that reads and trims complete lines of input - Updated
WithDefaultto useLineinstead ofPfor input handling - Replaced
prompt.Pwithprompt.Linein the project creation flow
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| clients/cli/cmd/internal/prompt/prompt.go | Added Line function for reading complete lines and updated WithDefault to use it |
| clients/cli/cmd/internal/prompt/prompt_test.go | Added comprehensive test coverage for Line and WithDefault functions |
| clients/cli/cmd/internal/init.go | Updated project name input to use prompt.Line instead of prompt.P |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jablan
reviewed
Feb 2, 2026
jablan
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
This PR fixes an issue where creating projects from the CLI with spaces in their names was not working correctly. The fix introduces a new
Linefunction that properly handles user input by trimming whitespace, replacing the previousPfunction which usedfmt.Scanand stopped reading at the first whitespace character.Changes:
Any affected ticket/issue:
Screenshots: