Skip to content

feat(go): More accurate config section naming #SCD-687 #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jablan merged 1 commit into from
Jan 27, 2026
Merged

feat(go): More accurate config section naming #SCD-687 #1037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions clients/go/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package phrase
import (
"errors"
"fmt"
"io/ioutil"
"os"
"path/filepath"

Expand Down Expand Up @@ -32,8 +31,8 @@ type Config struct {

Defaults map[string]map[string]interface{}

Targets []byte
Sources []byte
Pull []byte
Push []byte

UserAgent string
}
Expand Down Expand Up @@ -83,7 +82,7 @@ func configContent(cfgFilePath string) ([]byte, error) {
case path == "":
return nil, nil
default:
return ioutil.ReadFile(path)
return os.ReadFile(path)
}
}

Expand Down Expand Up @@ -141,8 +140,8 @@ func (cfg *Config) UnmarshalYAML(unmarshal func(i interface{}) error) error {
"per_page": &cfg.PerPage,
"project_id": &cfg.DefaultProjectID,
"file_format": &cfg.DefaultFileFormat,
"push": &cfg.Sources,
"pull": &cfg.Targets,
"push": &cfg.Push,
"pull": &cfg.Pull,
"defaults": &m,
})
if err != nil {
Expand Down
Loading