Skip to content

Hide (packed) hint for ZEND_INIT_ARRAY with op1=UNUSED #20982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
iluuu1994 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Hide (packed) hint for ZEND_INIT_ARRAY with op1=UNUSED #20982

iluuu1994 wants to merge 1 commit into from
+6 −6

Conversation

@iluuu1994
Copy link
Member

@iluuu1994 iluuu1994 commented Jan 20, 2026

Fixes GH-20978

@iluuu1994 iluuu1994 requested a review from TimWolla January 20, 2026 12:00
TimWolla
TimWolla reviewed Jan 20, 2026
View reviewed changes
Zend/Optimizer/zend_dump.c
}
}
if (ZEND_VM_EXT_ARRAY_INIT & flags) {
fprintf(stderr, " %u", opline->extended_value >> ZEND_ARRAY_SIZE_SHIFT);
Copy link
Member

@TimWolla TimWolla Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially even this should be suppressed, since no initialization is happening? No strong opinion either way, not my primary area of the code.

@ndossche
Copy link
Member

ndossche commented Jan 20, 2026

This is good, but one more nit:
In my opinion, it should be the other way around. Now it checks if ZEND_ARRAY_NOT_PACKED is set and then claims the array is packed, but this is not true, it's the other way around. ZEND_ARRAY_NOT_PACKED means that the array will be initialised as mixed, there is no explicit initialisation for packed hashtables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimWolla TimWolla TimWolla approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov will be requested when the pull request is marked ready for review dstogov is a code owner

@bukka bukka Awaiting requested review from bukka bukka will be requested when the pull request is marked ready for review bukka is a code owner

Assignees

No one assigned

Labels

Category: Optimizer Extension: standard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OPcode dump of ZEND_INIT_ARRAY should not show (packed) if OP1 is unused

3 participants

@iluuu1994 @ndossche @TimWolla